Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YALB-1505 - Controls: Disable animation per block #286

Merged
merged 6 commits into from
Sep 8, 2023
Merged

YALB-1505 - Controls: Disable animation per block #286

merged 6 commits into from
Sep 8, 2023

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Sep 5, 2023 •
edited by dblanken-yale
Loading

YALB-1505 - Controls: Disable animation per block

Description of work

  • Adds animate_item logic to card_collections
  • Changes animate_item to use enabled and disabled instead of true false.

Testing Link(s)

Functional Review Steps

@netlify
Copy link

netlify bot commented Sep 5, 2023 •
edited
Loading

✅ Deploy Preview for dev-component-library-twig ready!

Name Link
🔨 Latest commit 7634bfc
🔍 Latest deploy log https://app.netlify.com/sites/dev-component-library-twig/deploys/64fa96b42d4e3400086fa2af
😎 Deploy Preview https://deploy-preview-286--dev-component-library-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joetower joetower mentioned this pull request Sep 5, 2023
Closed
20 tasks
@joetower joetower changed the title fix(yalb-feat-motion): add motion var to card collection, enable/disable YALB-1505 - Controls: Disable animation per block Sep 5, 2023
@joetower joetower self-assigned this Sep 5, 2023
@joetower joetower marked this pull request as ready for review September 5, 2023 15:29
codechefmarc
codechefmarc approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, approved! I assume the Drupal part of this is in another castle PR.

dblanken-yale
dblanken-yale approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is working great! I did have a question that might be out of scope though; on the Post Grid Custom should those be animated in the same way the Event Grid is where the image moves slightly? I'm not seeing that, but if it was not part of this, that's fine. Just thought I'd ask.

I think using enabled/disabled is the right move.

https://deploy-preview-286--dev-component-library-twig.netlify.app/?path=/story/page-examples-post--post-grid-custom

@joetower
Copy link
Contributor Author

joetower commented Sep 6, 2023 •
edited
Loading

@dblanken-yale Ah, so, that page is actually just rough html markup. It was created to show unique content in a card collection grid. Good catch!

I pushed up a fix to make it work. It should for the purpose it needs to serve. I'm curious if we still need this page example, but we can open that for discussion. https://deploy-preview-286--dev-component-library-twig.netlify.app/?path=/story/page-examples-post--post-grid-custom

@nJim nJim merged commit 4fd3e16 into develop Sep 8, 2023
1 check passed
@nJim nJim deleted the feat-motion branch September 8, 2023 03:36
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🎉 This PR is included in version 1.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblanken-yale dblanken-yale dblanken-yale approved these changes

@codechefmarc codechefmarc codechefmarc approved these changes

@nJim nJim nJim approved these changes

Assignees

@joetower joetower

Labels
pass code review pass functional review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joetower @nJim @codechefmarc @dblanken-yale